GH Actions: Fix code formatter action#51
Merged
ktf merged 2 commits intoAliceO2Group:masterfrom Nov 19, 2024
Merged
Conversation
singiamtel
force-pushed
the
fix_gh_format
branch
from
d80433c to
044f009
Compare
Member
|
Is this triggering new formatting errors? |
Collaborator
Author
Hmm, good question. Apparently it wants to change The changes when formatting everything: src/Configuration.cxx | 3 +--
src/Daemon.cxx | 1 -
src/Exception.cxx | 1 -
src/Iommu.cxx | 1 -
src/LineBuffer.cxx | 3 +--
src/MemPool.cxx | 5 ++---
src/Program.cxx | 1 -
src/SimpleLog.cxx | 3 +--
src/SuffixNumber.cxx | 1 -
src/System.cxx | 1 -
src/Thread.cxx | 1 -
test/TestBasicThread.cxx | 1 -
test/TestIommu.cxx | 1 -
test/TestSuffixNumber.cxx | 1 -
test/TestSuffixOption.cxx | 1 -
test/TestSystem.cxx | 1 -
test/testDaemon.cxx | 1 -
test/testFifo.cxx | 1 -
test/testSimpleLog.cxx | 7 +++----
test/testTimer.cxx | 1 -
20 files changed, 8 insertions(+), 28 deletions(-) |
Member
|
@sy-c can you have a look if this is fine for you? In principle it matches better the coding conventions and it seems trivial changes. |
Collaborator
|
Hello @ktf, ok for me. |
singiamtel
added a commit
to singiamtel/Common
that referenced
this pull request
Nov 14, 2024
As discussed in AliceO2Group#51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the CI issues on #46 and #47
CC @ktf
The required job
clang-format-8has to be changed when merging